On Jan 23, 2008 5:53 PM, James Hawkins truiken@gmail.com wrote:
On Jan 23, 2008 5:20 AM, Paul Vriens paul.vriens.wine@gmail.com wrote:
Hi,
Currently the install test fail/crash on at least win95 and NT4. The main reason I found was that pMsiQueryComponentStateA and pMsiSourceListGetInfoA are not guarded.
Does it makes sense to guard every instance of these calls and just continue:
if (pMsiSourceListGetInfoA) { call test outcome }
or should we skip the whole subtest when the function is not available.
Guarding each single item requires 28 of these if-statements or is there an other alternative? (like creating a function/macro to deal with this)
Logically, guarding each call is the exact same as not running the tests at all, so just check at the beginning of test_MsiSourceListGetInfo and skip the tests if the pointer is NULL.
Well, I asked because there are more single tests in those subtests. As the 2 are mainly gathering information I thought to at least run the other ones.
As we are 'only' talking about win95 and NT4 I think I opt for your statement to just guard at the beginning. If we ever find an app that doesn't install on win95/NT4 and relies on the now not running tests we can always change that.
Cheers,
Paul.