Re: [PATCH vkd3d 04/17] vkd3d-shader/hlsl: Propagate constant loads in copy propagation.

[Matteo Bruni]

On Wed, Dec 1, 2021 at 5:46 PM Zebediah Figura  wrote:
> On 12/1/21 10:14, Matteo Bruni wrote:
> > From: Giovanni Mascellani
> > Signed-off-by: Matteo Bruni
> >
> > changelog: Try constant propagation first.
> >
> > libs/vkd3d-shader/hlsl_codegen.c | 51 ++++++++++++++++++++++++++++++++
> >   1 file changed, 51 insertions(+)
>
> I'm afraid I don't understand; what exactly is this patch doing that
> 1/17 doesn't?

IIRC this patch gets rid of unnecessary copies from an immediate to a
temporary variable. I already forgot the details but I'm pretty sure
that it did something...

I guess I'll have another look at some point, it's possible that it's
just hiding a bug or something like that.