Re: [PATCH 2/7] ieframe: Implement IOleObject::Advise().

[Jacek Caban]

Hi Dmitry,

On 27.07.2020 12:32, Dmitry Timoshkov wrote:
> Based on ole32/defaulthandler.c implementation.
> Signed-off-by: Dmitry Timoshkov
>
> dlls/ieframe/ieframe.h    |  2 ++
>   dlls/ieframe/oleobject.c  | 15 ++++++++++++---
>   dlls/ieframe/webbrowser.c |  3 +++
>   3 files changed, 17 insertions(+), 3 deletions(-)

Please add some test cases. For this series, at least some basic calls 
should be easy to test. However, are those callbacks supposed to be 
called? If yes, then this is rather a "semi-stub" implementation and 
would be good to mark it as such. Ideally, we'd have the object advised 
in something like test_WebBrowser to see if/how are those callbacks used.

Thanks,

Jacek