Re: [PATCH 2/4] gdi32: Add more emf StretchBlt tests.

[Huw Davies]

On Mon, May 17, 2021 at 05:00:07PM +0800, Zhiyi Zhang wrote:
> Signed-off-by: Zhiyi Zhang
>
> dlls/gdi32/tests/metafile.c | 1249 ++++++++++++++++++++++++++++++-----
>  1 file changed, 1096 insertions(+), 153 deletions(-)
>
> diff --git a/dlls/gdi32/tests/metafile.c b/dlls/gdi32/tests/metafile.c
> index 83a10264589..0e35e02b8da 100644
> --- a/dlls/gdi32/tests/metafile.c
> +++ b/dlls/gdi32/tests/metafile.c

[...]
> - /* Test StretchBlt with different format of bitmaps */
> - for (test_idx = 0; test_idx < ARRAY_SIZE(tests); ++test_idx)
> - {
> -
>    /* Don't run tests failing on Wine */
> -
>    if (tests[test_idx].todo && !strcmp(winetest_platform, "wine"))
> -
>        continue;

I'm not a fan of this.  You do remove it with the next patch, so I
could pretend I didn't see it.  OTOH, you could reorder the series and send
this after the implementation.

Huw.