Re: [PATCH v2 3/6] d3dx10_43: Share code for resource data loading.

[Matteo Bruni]

On Thu, May 26, 2022 at 6:32 PM Piotr Caban  wrote:
> Signed-off-by: Piotr Caban
>
> dlls/d3dx10_43/async.c     | 93 ++++++++++++++++++++++++++++----------
>   dlls/d3dx10_43/compiler.c  | 34 ++------------
>   dlls/d3dx10_43/dxhelpers.h |  4 ++
>   dlls/d3dx10_43/texture.c   | 70 ++++------------------------
>   4 files changed, 89 insertions(+), 112 deletions(-)

Just a nitpick:
> - if (!(rsrc = FindResourceA(module, resource, (const char *)RT_RCDATA)))
> -
>    rsrc = FindResourceA(module, resource, (const char *)RT_BITMAP);
> - if (!rsrc)
> - hr = load_resource_initA(module, resource, &rsrc);
> - if (FAILED(hr))

We usually tend to put the call inside the condition in "d3d" code. I
don't personally mind too much though.