On Do, 2006-10-05 at 08:09 -0600, Vitaliy Margolen wrote:
diff --git a/dlls/dinput/dinput_main.c b/dlls/dinput/dinput_main.c
if ((mod = GetModuleHandleA( "winex11.drv" )))
When we force wine to use a specific Display/Input-Driver, the driver-selection by reading the Registry is unneeded and should be removed.
IMHO, the clean way is to use the dynamic Driver Name, build from the Registry (preferable by a common used wine specific Function in a dll).
- = (void*) GetProcAddress(mod, "wine_tsx11_acquire_mouse");
The exported name is also not generic.
And we have both issues already:
$ grep -i --line-number "winex11.drv" dlls/*/* dlls/imm32/imm.c:143: x11drv = GetModuleHandleA("winex11.drv");
dlls/opengl32/wgl.c:637: HMODULE mod = GetModuleHandleA( "winex11.drv" );
dlls/wined3d/wined3d_main.c:113: mod = GetModuleHandleA( "winex11.drv" );
dlls/wintab32/wintab32.c:77: hx11drv = GetModuleHandleA("winex11.drv");
Exported Name: dlls/wined3d/wined3d_main.c:116: ... = (void *)GetProcAddress( mod, "wine_tsx11_lock" );