Re: [PATCH 2/2] ntdll/tests: Add RtlLCIDToCultureName tests.

[Mark Harmstone]

On 8/4/21 6:06 pm, Alexandre Julliard wrote:
> There is nothing MUI-specific about RtlLCIDToCultureName. The tests
> should go along with other similar functions in
> dlls/kernel32/tests/locale.c. It should also reuse the existing test
> data, there's no need to do exhaustive testing of all possible locales.

That's because my full MUI test is some 1400 lines long, which to my mind is substantial enough to warrant its own test...

Also, you want a ntdll function to be tested in the kernel32 test suite? That seems very counter-intuitive.

Finally, one thing I discovered, but left out of the test, is that Wine's custom kw-GB uses what's now a valid LCID for another language. You blatantly need full testing of all possible locales *somewhere*.