On Tue, 2 Mar 2021 at 18:39, Paul Gofman pgofman@codeweavers.com wrote:
On 3/2/21 20:30, Henri Verbeet wrote:
On Tue, 2 Mar 2021 at 18:03, Paul Gofman pgofman@codeweavers.com wrote:
On 3/2/21 19:16, Henri Verbeet wrote:
Shouldn't we also check whether we have a hardware device or not here?
Do you mean checking if we have a hardware renderer at all and skip the attempt to create draw_texture if we don't? But wouldn't it be easier to just let it fail without adding an extra check?
No, the other way around, there's no need to create the extra texture if we do have a hardware device. Granted, that only makes a difference if applications create system memory surfaces with the relevant caps on a hardware device, but well, ddraw applications.
But the application device might not exist yet at the moment it creates the surface, so it is not clear yet if it will be software or hardware device. Then, if the application will create the sysmem render target and will try to attach it to hardware device, it will fail anyway. Then, while we currently support just one ddraw device as I understand there is no such limitation on Windows and looks a bit undesirable to me to depend on the present limitation. Or am I missing something?
No, you're right, that makes sense.