El lun, 14 feb 2022 a la(s) 14:52, Zebediah Figura (zfigura@codeweavers.com) escribió:
On 2/14/22 03:56, Hans Leidekker wrote:>> SECURITY_STATUS WINAPI NCryptCreatePersistedKey(NCRYPT_PROV_HANDLE, NCRYPT_KEY_HANDLE *, const WCHAR *, const WCHAR *, DWORD, DWORD);
SECURITY_STATUS WINAPI NCryptDecrypt(NCRYPT_KEY_HANDLE, BYTE *,
DWORD, void *, BYTE *, DWORD, DWORD *, DWORD);
SECURITY_STATUS WINAPI NCryptEncrypt(NCRYPT_KEY_HANDLE, BYTE *,
DWORD, void *, BYTE *, DWORD, DWORD *, DWORD);
SECURITY_STATUS WINAPI NCryptFinalizeKey(NCRYPT_KEY_HANDLE, DWORD); SECURITY_STATUS WINAPI NCryptFreeObject(NCRYPT_HANDLE); SECURITY_STATUS WINAPI NCryptOpenKey(NCRYPT_PROV_HANDLE,
NCRYPT_KEY_HANDLE *, const WCHAR *, DWORD, DWORD);
+SECURITY_STATUS WINAPI NCryptImportKey(NCRYPT_PROV_HANDLE provider,
NCRYPT_KEY_HANDLE decrypt_key,
const WCHAR *type,NCryptBufferDesc *params, NCRYPT_KEY_HANDLE *key,
PBYTE data, DWORD datasize,DWORD flags);
SECURITY_STATUS WINAPI NCryptOpenStorageProvider(NCRYPT_PROV_HANDLE
*, const WCHAR *, DWORD);
Parameter names are not very useful here. Please keep these sorted.
I suppose it's a matter of taste, but for what it's worth, I tend to find them nice when calling functions, i.e. I can easily look up the signature in the header.
I think for now I will leave it without the parameter names because that's how it was coded originally, but to be honest I also like to have parameter names in the signature for the intellisense.