Re: bogus patch to bind() dlls/winsock/socket.c (request removal)

[Jeremy White]

Jeremy Shaw wrote:
> As a result of this patch (which is currently applied in cvs head):
>
> http://www.winehq.com/hypermail/wine-patches/2002/12/0009.html

This also makes the Quicktime player unable to view
streaming video, although I have to confess I do not
know why, except that the bind failure seems to make
the player take a slightly different path.

With this change, we can use the 6.3 version of Quicktime
to see streamed video from Wineconf...

In the hopes it'll get noticed, here's a patch to remove it:

Changelog:
   Jeremy Shaw 
   Remove forced WS_SO_REUSEADDR on all binds

Index: dlls/winsock/socket.c
===================================================================
RCS file: /home/wine/wine/dlls/winsock/socket.c,v
retrieving revision 1.144
diff -u -r1.144 socket.c
--- dlls/winsock/socket.c	2 Jan 2004 20:12:00 -0000	1.144
+++ dlls/winsock/socket.c	10 Jan 2004 22:56:57 -0000
@@ -1302,10 +1302,6 @@
              else
              {
                  int on = 1;
-                /* The game GrandPrixLegends binds more than one time, 
but does
-                 * not do a SO_REUSEADDR - Stevens says this is ok */
-                TRACE( "Setting WS_SO_REUSEADDR on socket before we 
bind it\n");
-                WS_setsockopt( s, WS_SOL_SOCKET, WS_SO_REUSEADDR, 
(char*)&on, sizeof(on) );

if (bind(fd, uaddr, uaddrlen) < 0)
                  {