Re: [PATCH] compobj.dll16: Implement CoGetClassObject().

[Zebediah Figura]

On 02/08/2017 03:54 AM, Huw Davies wrote:
> On Sat, Feb 04, 2017 at 07:47:32PM -0600, Zebediah Figura wrote:
> > Fixes bug https://bugs.winehq.org/show_bug.cgi?id=41209
> > Signed-off-by: Zebediah Figura
> >
> > dlls/compobj.dll16/compobj.c          | 242

+++++++++++++++++++++++++++++++---
> > dlls/compobj.dll16/compobj.dll16.spec |   2 +-
> >  2 files changed, 222 insertions(+), 22 deletions(-)
>
> Hi Zebediah,
>
> This patch could be split into a series of smaller patches.
> For example, implement CoGetClassObject16() first, then
> CoCreateInstance16() as a seperate patch, and then CoFreeAllLibraries().
>
> I've inlined some comments below.

Thanks for the comments. Most of the code was copied from the 32-bit
version, so my variable naming (and code structure) was not as good and
consistent as it should have been.