Re: [PATCH] riched20: Implement ITextSelection::GetText. (try 2)

[Huw Davies]

On Wed, Jul 02, 2014 at 08:01:32PM +0800, Jactry Zeng wrote:
> --- a/dlls/riched20/richole.c
> +++ b/dlls/riched20/richole.c
> @@ -783,11 +783,32 @@ static HRESULT WINAPI ITextSelection_fnInvoke(
>  static HRESULT WINAPI ITextSelection_fnGetText(ITextSelection *me, BSTR *pbstr)
>  {
>      ITextSelectionImpl *This = impl_from_ITextSelection(me);
> - ME_Cursor *start = NULL, *end = NULL;
> - int nChars;
> - if (!This->reOle)
>        return CO_E_RELEASED;
> - TRACE("%p\n", pbstr);
> - if (!pbstr)
> -
>    return E_INVALIDARG;
>
> - FIXME("not implemented\n");
> - return E_NOTIMPL;
> - ME_GetSelection(This->reOle->editor, &start, &end);
> - nChars = ME_GetCursorOfs(end) - ME_GetCursorOfs(start);
> - TRACE("%p, %p\n", start, end);

This TRACE isn't very useful.  Either print out the cursors' values
or remove it.  Other than that, this looks good to me.

Huw.