Re: Aw: [PATCH 2/2] vbscript: Implement DateAdd().

[Nikolay Sivov]

On 5/16/22 14:43, Robert Wilhelm wrote:
> Hi Nikolay,
> Thanks for working on vbs builtin.
> On minor nit:
> If we pass NULL as argument, we get error type mismatch instead of illegal null
> usage.
> In some builtins, we explicitely check for NULL like following:
>     if(V_VT(arg) == VT_NULL)
>           return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE);
> Quite a few builtins lack these checks...

Yes, that's very true. I have a handful of extra patches, that use 
single helper for all conversion functions like CInt(), so I can do this 
null check in one place. Maybe it could be generalized at lop level, 
checking for null before Global_* functions are called, I haven't tested 
that far.
> Best regards,
> Robert