Re: [PATCH 5/5] d3dx9/tests: Add tests for normals computation.

[Józef Kucia]

On Mon, Jul 27, 2015 at 7:40 PM, Matteo Bruni  wrote:
> > - static const D3DVERTEXELEMENT9 position3f_normal1f_declaration[] =
> > - {
> > -
> >    {0, 0,                   D3DDECLTYPE_FLOAT3, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_POSITION, 0},
> > -
> >    {0, sizeof(D3DXVECTOR3), D3DDECLTYPE_FLOAT1, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_NORMAL,   0},
> > -
> >    D3DDECL_END()
> > - };
> > - static const D3DVERTEXELEMENT9 position3f_normal2f_declaration[] =
> > - {
> > -
> >    {0, 0,                   D3DDECLTYPE_FLOAT3, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_POSITION, 0},
> > -
> >    {0, sizeof(D3DXVECTOR3), D3DDECLTYPE_FLOAT2, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_NORMAL,   0},
> > -
> >    D3DDECL_END()
> > - };
> > - static const D3DVERTEXELEMENT9 normal4f_position3f_declaration[] =
> > - {
> > -
> >    {0, 0,                   D3DDECLTYPE_FLOAT4, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_NORMAL,   0},
> > -
> >    {0, sizeof(D3DXVECTOR4), D3DDECLTYPE_FLOAT3, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_POSITION, 0},
> > -
> >    D3DDECL_END()
> > - };
>
> Can you check that a 4-component normal placed after the position
> gives the same results? It doesn't need to be in the patch if there
> are no surprises (and there shouldn't be, this is me being paranoid).

No surprises.