Re: [PATCH 3/4] msvcrt: Implement the tgamma functions

[Martin Storsjö]

On Thu, 1 Aug 2019, Piotr Caban wrote:
> Hi Martin,
>
> On 7/30/19 11:08 PM, Martin Storsjo wrote:
> > +/*********************************************************************
> > -
> > -
> >  tgamma (MSVCR120.@)
> > - */
> >
> > +double CDECL MSVCR120_tgamma(double x)
> > +{
> > +#ifdef HAVE_TGAMMA
> > - return tgamma(x);
> >
> > +#else
> > - FIXME( "not implemented\n" );
> > - return 0.0;
> >
> > +#endif
> > +}
>
> Isn't the function supposed to set error on invalid arguments?

Yes, that's true. I'll add support for that.

FWIW, I believe setting of errno is missing in quite a few other math 
functions, at least lgamma to name one.

// Martin