On 12/6/21 23:18, Paul Gofman wrote:
Do I understand correctly that the main purpose of these patches is to provide the debugger an opportunity to see (and potentially handle) second chance exception? As it probably doesn't matter too much how exactly the process will fail after second chance exception in the absence of debugger. In any case, that probably deserves some debugger tests? The majority of existing debugger tests is in ntdll/tests/exception.c:test_debugger().
Since second chance exceptions are inherently nonrecoverable, perhaps it should be placed at the end in the debuggee?
Or maybe write a dedicated function that tests just this one.
P.S. the change test fail seems to be a uncaught regression from earlier commits.