Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template

[Dmitry Timoshkov]

Eric Pouech  wrote:
> MMRESULT WINAPI acmFormatChooseW(PACMFORMATCHOOSEW pafmtc)
>  {
> - return DialogBoxParamW(MSACM_hInstance32, MAKEINTRESOURCEW(DLG_ACMFORMATCHOOSE_ID),
> -
>                       pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc);
> - MMRESULT    ret;
> -
> - if (pafmtc->fdwStyle & ACMFORMATCHOOSE_STYLEF_ENABLETEMPLATEHANDLE)
> -
>    ret = DialogBoxIndirectParamW(MSACM_hInstance32, (LPCDLGTEMPLATEW)pafmtc->hInstance,
> -
>                                  pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc);
> - else if (pafmtc->fdwStyle & ACMFORMATCHOOSE_STYLEF_ENABLETEMPLATE)
> -
>    ret = DialogBoxParamW(pafmtc->hInstance, pafmtc->pszTemplateName,
> -
>                          pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc);
> - else
> -
>    ret = DialogBoxParamW(MSACM_hInstance32, MAKEINTRESOURCEW(DLG_ACMFORMATCHOOSE_ID),
> -
>                          pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc);
> - return ret;
>
> }

It would look much better without all those 'ret' + 'else' things.