On 8/29/20 1:09 PM, Nikolay Sivov wrote:
On 8/29/20 7:29 PM, Derek Lesho wrote:
On 8/29/20 1:30 AM, Nikolay Sivov wrote:
I was thinking we will be keeping this stub until winegstreamer changes are in and got tested enough. Not sure what the current situation is on macos, maybe we'll need this stub until we have a bridge to newer multimedia API, now that quicktime one is deprecated.
I'm fine with keeping or it or removing it. In my initial patch I preserved it, at the expensive of uglier testing code. However, what's the purpose of the stub in the first place? Do any applications rely on it being present?
We either keep it until we have something better or remove it only to find out what breaks.
It seems unlikely that anything will break. I tested Disgaea, which the hack was written for, and it works fine if lookup of the media source fails. I think it would take a very strange application to not handle the failure of creating a media source, yet gracefully handle failure when interacting with the presentation descriptor. If anything, removing the stub might improve compatibility.