Re: Non-perfect epoll patch

[Mike McCormack]

Shachar Shemesh wrote:
> Hi all,
>
> Attached is a non-perfect patch for review. This is a migration of the 
> wineserver to use epoll instead of poll (if it's available).
>
> current known issue with this patch:
> - Will not compile if HAVE_SYS_EPOLL_H is not 1 (i.e. - won't compile
>
> if epoll not available at compile time)
> 2. Segfaults on wine exit.
> 3. Lots of debug asserts.
>
> Comments welcome.
>             Shachar

If you're going to use syscalls instead of epoll_create etc, then you 
don't need to check whether epoll functions exist in glibc, since you're 
not using them anyway.

In any case, seeing that getting your patch accepted will take some 
effort, it's probably a good idea to use the glibc version functions 
first, and deal with the problem of missing epoll functions in older 
glibcs in a seperate patch.

Mike