Re: [PATCH 2/2] Quickly retry sendmsg or recvmsg if errno is EAGAIN or EINTR.

[Erich E. Hoover]

On Wed, Feb 26, 2014 at 4:26 PM, Max Woodbury  wrote:
> Please explain in words of one syllable why this has been rejected?

Probably for the reasons Ken already mentioned:
1) Strange blank line after "if (n == -1)"
2) Unnecessary style change to K&R style ("if (ret >= 0) {")
3) "[PATCH 2/2]" with no "[PATCH 1/2]"
4) No explanation for his comment that EAGAIN is probably not needed.
EINTR might want this behavior, but EGAIN should not.
5) If you bring this code "down" to where you have then you need to
remove it from the "higher" level:
http://source.winehq.org/source/dlls/ws2_32/socket.c#L4494
http://source.winehq.org/source/dlls/ws2_32/socket.c#L6500
6) It should be in a loop

Does that help?

Best,
Erich