Re: mmsystem 16bit questions

[Alexandre Julliard]

 writes:
> I believe:
> - SEGPTR should be used everywhere the .spec says;
> - (DWORD_PTR) cast then becomes obsolete.
>
> Shall I submit a patch?

Yes, SEGPTR would be preferable.
> Furthermore, how to perform a 16bit NULL pointer check?
> waveInUnPrepareHeader16 uses:
>     LPWAVEHDR           lpWaveOutHdr = MapSL(lpsegWaveOutHdr);
>     if (lpWaveInHdr == NULL) return MMSYSERR_INVALPARAM;
> waveInAddBuffer16 directly uses:
>     if (lpsegWaveInHdr == NULL) return MMSYSERR_INVALPARAM;

Either way is fine, MapSL(NULL) == NULL.