On 06/10/2021 21:15, Jacek Caban wrote:
Hi Gabriel,
On 10/6/21 5:11 PM, Gabriel Ivăncescu wrote:
+ if(!obj) { + win_skip(msg + " is buggy and not available, skipping"); + return; + }
Where do you see it happening? It seems to be unneeded for this patch and if you need it later, it's probably better to handle in the caller rather than the generic helper.
Thanks,
Jacek
Yeah it's pretty weird. Seems to happen on the w10pro64 VM for some reason.
https://testbot.winehq.org/JobDetails.pl?Key=99570&f212=exe32.report#k21...
So far only currentStyle seems to be also needing special handling.
The thing is that, while testing this out, the getClientRects() also had such bug, but I wasn't able to reproduce it on the testbots again after that (I can't reproduce any of them at all locally).
So I tried to play it safe and put it in the test function itself—but if that's not desirable I can add exception just for currentStyle. I just hope nothing else pops up randomly at some point.