Am 10.04.2014 um 09:18 schrieb Stefan Dösinger stefandoesinger@gmail.com:
You shouldn’t have to set client->init = FALSE because you allocate client with HEAP_ZERO_MEMORY. If you prefer to set it for clarity that’s ok with me.
The same applies to SP_guid, for two reasons: First, it’s already initialized to zeroes, and you’re not reading it unless client->init is set to TRUE, which only happens after a successful SetSP call.
IMHO you can also correct the indentation in this function, but I’ll leave the decision up to you.
To clarify: Only change the indentation when you change something else in the function.
/me blames the accidental wine-patches CC on Apple Mail…