On 03/11/2011 06:50 AM, Henri Verbeet wrote:
Sigh. I've asked you a very simple question about the performance impact of these changes *twice* now, and you ignored the question both times.
Unless you have evidence that the compiler fails to eliminate the call by itself, and this actually makes any kind of difference, consistency is more important.
Obviously for a change this small the difference is not measurable. I don't think trivial function calls are ever correct, here or anywhere else. I don't know whether that call compiles out, but I know for sure that a comment does.