Re: [PATCH 2/3] dmloader: Display new ref in AddRef and Release.

[Alistair Leslie-Hughes]

Hi,

On 6/11/2012 7:05 PM, Christian Costa wrote:
> static HRESULT WINAPI IDirectMusicLoaderImpl_IDirectMusicLoader_GetObject(LPDIRECTMUSICLOADER8 iface, LPDMUS_OBJECTDESC pDesc, REFIID riid, LPVOID* ppv)
> @@ -880,7 +884,7 @@ HRESULT WINAPI DMUSIC_CreateDirectMusicLoaderImpl (LPCGUID lpcGUID, LPVOID *ppob
>    	return E_OUTOFMEMORY;
>    }
>    obj->IDirectMusicLoader8_iface.lpVtbl = &DirectMusicLoader_Loader_Vtbl;
> - obj->dwRef = 0; /* will be inited with QueryInterface */
> - obj->ref = 0; /* Will be inited with QueryInterface */

Shouldn't obj->ref start at 1 or else it will never be freed.

Best Regards
  Alistair Leslie-Hughes