On 10/20/21 7:46 PM, Jefferson Carpenter wrote:
On 10/8/2021 8:30 PM, Jefferson Carpenter wrote:
Removed vb_reader_support_data. Looped through reader_support_data, but incremented a flag through SAXObjectType and VB_SAXObjectType while incrementing the table.
Hey, any thoughts on this patch?
I still think there is no reason for it to change that much, it's still ~1400 lines diff.
This patch is RE the email from several months ago saying that altering the parseURL behavior would be more acceptable if there were tests for the VB saxreader class. I would rather add tests and fix parseURL in the right place than just fix it for the non-VB saxreader. This is eventually to fix https://bugs.winehq.org/show_bug.cgi?id=51267
Could you explain how it's crashing? Maybe we could have more targeted test for this specific problem instead.
Thanks! Jefferson