Re: mshtml: Added beginning ActiveX tests.

[Paul Vriens]

On 11/30/2010 01:56 PM, Paul Vriens wrote:
> Hi Jacek,
>
> On 11/30/2010 01:38 PM, Jacek Caban wrote:
> > +static HRESULT WINAPI
> > PropertyNotifySink_OnChanged(IPropertyNotifySink *iface, DISPID dispID)
> > +{
> > - if(dispID == DISPID_READYSTATE){
> > - BSTR state;
> > - HRESULT hres;
> > -
> > - static const WCHAR completeW[] = {'c','o','m','p','l','e','t','e',0};
> > -
> > - hres = IHTMLDocument2_get_readyState(notif_doc,&state);
> > - ok(hres == S_OK, "get_readyState failed: %08x\n", hres);
> > -
> > - if(!lstrcmpW(state, completeW))
>
> This will always succeed on Win9x.
> > +static HWND create_container_window(void)
> > +{
> > - static const WCHAR wszHTMLDocumentTest[] =
> > - {'H','T','M','L','D','o','c','u','m','e','n','t','T','e','s','t',0};
> > - static WNDCLASSEXW wndclass = {
> > - sizeof(WNDCLASSEXW),
> > - 0,
> > - wnd_proc,
> > - 0, 0, NULL, NULL, NULL, NULL, NULL,
> > - wszHTMLDocumentTest,
> > - NULL
> > - };
> > -
> > - RegisterClassExW(&wndclass);
> > - return CreateWindowW(wszHTMLDocumentTest, wszHTMLDocumentTest,
> > - WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, CW_USEDEFAULT,
> > - 515, 530, NULL, NULL, NULL, NULL);
> >
> > +}
>
> This will not work on Win9x as well. My Win98 box runs IE6 so it will
> run these tests I guess (unlike the win98 testbot).

This is what I get on my win9 box:

activex.c:480: Test failed: UIActivate failed: 800700b7
activex.c:486: Test failed: Show failed: 800700b7
activex: 24 tests executed (0 marked as todo, 2 failures), 0 skipped

Changing the lstrcmpW and using A-functions to create the window makes 
the tests succeed on my win98 box (changed activex.c attached).