Eric Pouech wrote:
Jon Bright wrote:
Alexandre Julliard wrote:
"BiGgUn" fbiggun@hotmail.com writes:
Changelog: Reorder lines for a typical winedbg configuration.
Your patch is wrapped; but anyway I don't see any reason to change that, keys are sorted when registry files are saved so the order doesn't matter.
This needs to change, though - for example, the tool palettes in C++Builder appear in the wrong order because of this.
I really don't see how changing the configuration (in a no op way) of the debugger would fix some window related issue elsewhere and if it's the case, it means something is severely broken in some other place => this is not the correct fix A+
These are two separate changes:
a) Wine's registry needs to preserve ordering (c++ builder, presumably among others) b) BiGgUn wants to reorder the winedbg lines for some reason. I'm not saying he's right (I don't understand why he wants to reorder things like that), but I am saying that if he is wrong, it's not because this would be reordered anyway. Basically, I'm not supporting his patch, I'm saying Alexandre's reason for rejection is wrong.
-- Jon Bright Lead Programmer, Silicon Circus Ltd. http://www.siliconcircus.com