On Thursday, 7 March 2024 14:51:57 CST DodoGTA GT wrote:
Hello,
I managed to prepare another round of patches for wine-staging (the last one is actually a Wine patch though and it's a bit hacky too so I'm not sure if it's a good solution)
Yeah, 4/4 is pretty much wrong.
3/4 doesn't look right either, or at least, it's suspicious that it matters. We don't pass application buffers directly to a system call anymore; there's a memcpy through random_buf in advapi32. Technically if someone put a write watch on advapi32's .data section that would make a difference, but that seems unlikely, and it's certainly not the case for services.exe. It needs more investigation.
I've applied 1/4 and 2/4, but again, in the future *please* stop sending diffs of diffs; they are much more time-consuming to review and apply. Please just send a single diff, or better yet apply the energy towards upstreaming these patches instead of just rebasing them.
Thanks!
--Zeb