Looks better.
Maybe create_gdi_logbrush should fall back to creating a solid brush, so that pens with weird brushes set will do something vaguely sensible. Eventually, we will want to use a different implementation of pens that does not involve gdi32 in those cases.
On Wed, Feb 29, 2012 at 2:29 AM, Dmitry Timoshkov dmitry@baikal.ru wrote:
Vincent Povirk madewokherd@gmail.com wrote:
The right solution is to remove the gdibrush and logbrush fields from GpBrush, and generate the HBRUSH as needed in brush_fill_path. Note that brush_fill_path will only be called for solid and hatch brushes (those for which brush_can_fill_path returns true), so we don't need the code to create a gdi brush for the other types.
Does the attached patch look better? Next step would be to get rid of bmp in GpSolidFill structure.
-- Dmitry.