On Tue, 27 Jul 2021 at 13:11, Ziqing Hui zhui@codeweavers.com wrote:
@@ -572,6 +579,12 @@ struct d2d_effect LONG refcount;
ID2D1Factory *factory;
- CLSID clsid;
- BOOL cached;
- UINT min_inputs;
- UINT max_inputs;
- D2D1_BUFFER_PRECISION precision;
- struct d2d_property standard_properties[10];
};
I don't think the fixed-size array of an arbitrary size is great. More, if these are static properties, there's really not much of a point in storing them like that; we could just as well store a static const table, not entirely unlike the builtin_effects[] table from patch 1/4.
Like patch 1/4, most of this patch is dead code.