"Louis. Lenders" xerox_xerox2000@yahoo.co.uk wrote:
i'm sure that if this function ever gets implemented all these checks and tests are needed, but as i said, a bit of google for fixme:GetVolumePath shows the common way (the very few) apps call this function is with filename="c:\blabla\bla", so for now , in my opinion, i don't think it's worth the effort.
A simple test would be very easy and would help convince Alexandre to apply your patch.
IMHO you should go drink a little bit of the koolaid at http://en.wikipedia.org/wiki/Test-driven_development Check it out; It even *sounds* like Wine development philosophy: ...
By focusing on writing only the code necessary to pass tests, designs can be cleaner and clearer than is often achieved by other methods[3]. In Test-Driven Development by Example Kent Beck also suggests the principle "Fake it, till you make it".
- Dan