Hey,
On 13-02-15 17:40, Sebastian Lackner wrote:
On 13.02.2015 17:22, Andrew Eikum wrote:
On Thu, Feb 12, 2015 at 03:46:24PM +0200, Damjan Jovanovic wrote:
AFAIK, even if for no other reason, this patch will probably be rejected because it patches configure, as opposed to just patching configure.ac and requesting configure to be regenerated.
That's a good point.
If my memory serves me right he will just ignore the configure changes and regenerate everything himself anyway, so I doubt it will cause a rejection..
It might also have a better chance if broken up into several patches.
There isn't really a good way to split it up. I don't see any sense in submitting an unimplemented or half-broken driver.
Andrew
The patch doesn't even list all the authors involved. Mark Harmstone and Juergen Tretthahn are missing for example.
If it was up to me I would have done a pull request with a branch that only contains the winepulse changes so the complete history is kept. Unfortunately last time I tried this I didn't receive any response from AJ. Still you're right I should have mentioned the other authors involved: Mark Harmstone, Andrew Eikum, Jeff Klein (indirectly), Juergen Tretthahn, DGhost001 and fdel.
~Maarten