Re: [PATCH v4 1/4] d3d9/tests: Add Fetch4 tests

[Stefan Dösinger]

Hi,

I got some failures on r500 on Win7, I've attached the test output. My
guess is that r500 applies fetch4 for ATI1, and there's still the
different green and blue components in DF24.

Evergreen has texldd and texldl failures. I think I did not see them
last time. Weird...

A few comments are inline. The general structure looks good to me.
Am 05.02.19 um 01:19 schrieb Daniel Ansorregui:
> -
>    BOOL broken_wine;           /* Do not check it on wine because is known to be broken */

I'd prefer the name "todo_wine". Wine isn't broken, it's just not
finished yet :-P. Only windows is broken().

(Jokes aside, I think it makes sense to stick to the names of
"todo_wine" and "broken()")
> -
>    const char * name;          /* The name of the texture format */

Minor nitpick: "const char *name;"
> - const BOOL isWin = strcmp(winetest_platform, "wine");

This is not used
> -
>        get_rt_readback(original_rt, &rb);
> -
>        D3DCOLOR color = get_readback_color(&rb, format_tests[i].x, format_tests[i].y);            

Trailing whitespace