Re: [PATCH 2/4] wined3d: Add fast-path for texture download blit.

[Henri Verbeet]

On Wed, 3 Oct 2018 at 19:33, Andrew Wesie  wrote:
> On Wed, Oct 3, 2018 at 10:16 AM Henri Verbeet  wrote:
> > Moving these down means uploads/downloads will potentially be used for
> > colour-key and alpha-test blits, which seems wrong. Was that change
> > intentional?
>
> The problem I was trying to solve is that blit_op = WINED3D_BLIT_OP_RAW_BLIT still needs to happen if we cannot do the download for some reason (e.g. texture sizes don't match). I agree that the change is not obviously correct.
>
> How about moving the upload / download to after the conditionals and verifying blit_op == WINED3D_BLIT_OP_RAW_BLIT?

Yeah, I think that makes sense, and I think it would actually slightly
simplify the upload/download branches.