Re: [PATCH v4 12/14] mshtml: Implement HTMLDocument's toString properly.

[Jacek Caban]

Hi Gabriel,

On 10/7/21 3:52 PM, Gabriel Ivăncescu wrote:
> diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c
> index 96a776d..59135f6 100644
> --- a/dlls/mshtml/dispex.c
> +++ b/dlls/mshtml/dispex.c
> @@ -1502,6 +1502,10 @@ HRESULT dispex_to_string(DispatchEx *dispex, BSTR *ret)
>       if(compat_mode < COMPAT_MODE_IE9)
>           p--;
>       else {
> -
>    if(dispex->info->desc->vtbl && dispex->info->desc->vtbl->get_compat_name) {
> -
>        const WCHAR *tmp = dispex->info->desc->vtbl->get_compat_name(compat_mode);
> -
>        if(tmp) name = tmp;
> -
>    }

I think it would be good to try harder to avoid this. I'm not sure if 
those differences are something we need to worry now, but this callback 
should not really be needed. If we need this, then we could use 
separated dispex descriptors for different document modes (but I'm not 
sure it's worth it, using IE11 names seems good enough).

Thanks,

Jacek