11 Jan
2013
11 Jan
'13
12:05 p.m.
On 11 January 2013 12:49, Stefan Dösinger stefandoesinger@gmail.com wrote:
I don't think it's worth a big argument and resent the patches without it, but IMO zeroing output structures in the tests makes sense. Ideally we'd have a test that explicitly tests if GetDeviceCaps clears the structure. All other tests should clear the structure to avoid randomness - there might be a third d3d9 implementation where the author forgot to clear the structure.
Perhaps if we were explicitly testing GetDeviceCaps(), but it's probably basic enough that it's not needed. Everywhere else, the same reasoning applies as for not checking that e.g. HeapAlloc() succeeds in tests.