Re: [PATCH] [d3dx9]: Add D3DXComputeTangentFrame implementation

[Matteo Bruni]

2017-12-05 22:50 GMT+01:00 Vijay Kiran Kamuju :
> Hi Matteo,

Hi!
> On Tue, Dec 5, 2017 at 8:47 PM, Matteo Bruni  wrote:
> > 2017-12-01 11:20 GMT+01:00 Vijay Kiran Kamuju :
> > > -
> > >        D3DDECLUSAGE_BINORMAL, 0, D3DDECLUSAGE_TANGENT, 0, D3DDECLUSAGE_NORMAL, 0,
> > > -
> > >        options | D3DXTANGENT_GENERATE_IN_PLACE,
> > > -
> > >        NULL, 0.01f, 0.25f, 0.01f, NULL, NULL);
> >
> > I think we want some tests, at the very least to confirm that those
> > are the correct arguments.
>
> I have used below MSDN docs :
> https://msdn.microsoft.com/en-us/library/windows/desktop/bb172744(v=vs.85).a...
> Do we still need tests?

Yes, MSDN is known not to be a reliable reference.