Re: wine/programs/regedit regproc.h regproc.c rege ...

[Vincent Béron]

Le jeu 14/08/2003 à 15:36, Dustin Navea a écrit :
> --- Vincent Béron  wrote:
> > @@ -153,6 +153,9 @@
> >          }
> >      }
> > - if (*s && action == ACTION_UNDEF)
> > -
> >    action = ACTION_ADD;
> > - if (action == ACTION_UNDEF)
> >        return FALSE;
>
> <IMHO> I think this would be a little cleaner (or at least easier to read):
> if (*s && action == ACTION_UNDEF)
>     action = ACTION_ADD;
> else if (action == ACTION_UNDEF)
>     return FALSE;

Sure, I agree with that. I was a bit in a hurry yesterday, when I
noticed while building RH8 and RH9 RPMs that I had a regedit window
(when the import was supposed to stay windowless) and that the file
hadn't be imported. My first goal was to get it to work correctly.
> that or
> if (action == ACTION_UNDEF)
> {
>     if (*s)
>         action = ACTION_ADD;
>     return FALSE;
> }

This won't do the same thing (the return statement will always be
executed).

Vincent