Frédéric Delanoy wrote:
On Thu, Jul 16, 2009 at 3:48 PM, Paul Vrienspaul.vriens.wine@gmail.com wrote:
Changelog Fix a crash on Vista and higher
-- Cheers,
Paul.
From b5e1d29ba2f5d5dd8a74c5b9abb301c0f81a5cb3 Mon Sep 17 00:00:00 2001 From: Paul Vriens Paul.Vriens.Wine@gmail.com Date: Thu, 16 Jul 2009 15:47:38 +0200 Subject: [PATCH] Fix a crash on Vista and higher
dlls/winhttp/tests/winhttp.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index 78c4777..bce91fe 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -905,10 +905,14 @@ static void test_set_default_proxy_config(void) len = get_default_proxy_reg_value( saved_proxy_settings, len, &type ); }
- SetLastError(0xdeadbeef);
- ret = WinHttpSetDefaultProxyConfiguration(NULL);
- ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER,
"expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError());
if (0)
{
/* Crashes on Vista and higher */SetLastError(0xdeadbeef);ret = WinHttpSetDefaultProxyConfiguration(NULL);ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER,"expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError());}
/* test with invalid access type */ info.dwAccessType = 0xdeadbeef;
-- 1.6.0.6
Maybe a stupid question, but why do you completely disable the test if "only" Vista and up are affected?
Frédéric
Sometimes it's easy to deduce the platform and act on it, sometimes it's not.
I guess it also makes a difference if we are talking about older or newer platforms. We tend to implement the latest functionality so we should most of the time cater for differences with older platforms.