RE: Win64 patch 3/6 (resend)

[Ge van Geldorp]

> From: Dmitry Timoshkov [mailto:[e-mail]]
>
> "Ge van Geldorp"  wrote:
> > --- a/include/wine/server_protocol.h
> > +++ b/include/wine/server_protocol.h
> > @@ -33,6 +33,9 @@ struct reply_header
> > struct request_max_size
> > {
> >     int pad[16];
> > +#ifdef _WIN64
> > - int pad64[10];
> >
> > +#endif
> > };
>
> Why is this required? Is that due to asserts in server/request.c,
> open_master_socket() ?

Exactly.
> Is changing 'int' to 'long' a better fix?

Perhaps. It would become

struct request_max_size
{
   long pad[10];
   int pad1[6];
};

then, which seems just as arbitrary.
> Also probably the fix should go in server/protocol.def instead.

Yes, you're right. I had missed the "automatically generated" comment at the
top of the include file. Will submit a new patch.

Gé van Geldorp.