Re: [PATCH 5/5] winevulkan: Implement VK_EXT_full_screen_exclusive

[Joshua Ashton]

Yes, that would be do-able. I will make that change.
I thought making them private thunks would be preferred but in
retrospect it does seem a bit poop.

- Josh

On Thu, 16 Jul 2020 at 17:32, Brendan Shanks  wrote:
> > On Jul 16, 2020, at 12:42 AM, Joshua Ashton  wrote:
> >
> > +VkResult WINAPI wine_vkGetPhysicalDeviceSurfacePresentModes2EXT(
> > - VkPhysicalDevice                            physicalDevice,
> > - const VkPhysicalDeviceSurfaceInfo2KHR*      pSurfaceInfo,
> > - uint32_t*                                   pPresentModeCount,
> > - VkPresentModeKHR*                           pPresentModes)
> >
> > +{
> > - TRACE("%p, %p, %p, %p", physicalDevice, pSurfaceInfo, pPresentModeCount, pPresentModes);
> > - return thunk_vkGetPhysicalDeviceSurfacePresentModesKHR(physicalDevice, pSurfaceInfo->surface, pPresentModeCount, pPresentModes);
> >
> > +}
> > -
> >
> > +VkResult WINAPI wine_vkGetDeviceGroupSurfacePresentModes2EXT(
> > - VkDevice                                    device,
> > - const VkPhysicalDeviceSurfaceInfo2KHR*      pSurfaceInfo,
> > - VkDeviceGroupPresentModeFlagsKHR*           pModes)
> >
> > +{
> > - TRACE("%p, %p, %p", device, pSurfaceInfo, pModes);
> > - return thunk_vkGetDeviceGroupSurfacePresentModesKHR(device, pSurfaceInfo->surface, pModes);
> >
> > +}
>
> Could you just call wine_vkGetPhysicalDeviceSurfacePresentModesKHR() and wine_vkGetDeviceGroupSurfacePresentModesKHR() here rather than having to make those private thunks?
> Similar to how wine_vkGetPhysicalDeviceProperties() is called elsewhere in the file (with a prototype manually added).
>
> Brendan