On Friday, December 30, 2011 1:41:12 PM Jeff Cook wrote:
Hello all
I am curious about the patch on http://bugs.winehq.org/show_bug.cgi?id=18490 and why it's not in vanilla. http://bugs.winehq.org/show_bug.cgi?id=18490#c9 seems to be a pretty cogent explanation of the issue and the patch appears reasonable enough.
Because it's not correct. OpenGL's SetPixelFormat on the desktop window (GetDC(0)) is supposed to fail, or at least did when I made tests for it a few years ago. I think a better fix would be for wined3d to use a dummy surface, or a renderless context (available with OpenGL 3.0), if it's asked to use the desktop window.