I din't know wine has a indentation style. This is good news. That said, I don't understand then why we don't just convert wine's code (in several steps off course) and avoid troubles particularity switch from one style to another depending on the dll we are working on. I recently implemented d3dxof using a 2 spaces indentation style. I don't even know what led me to use this style because I prefer 4 spaces. Maybe there was few lines using it and I sticked to this style. I don't remember. I don't know either how this code could have gone into git. :-| So next time I will convert d3dxof to 4 spaces and see what happens to the patch. ;-)
Bye, Christian
Detlef Riekenberg a écrit :
On So, 2009-03-29 at 12:50 +0200, Christian Costa wrote:
There are some discrepancies in the indentation and I don't mind removing tabs but what's wrong with them, they are commonly use in wine depending on one's taste.
Wine use 4 SPACE for indention. There is old code that use 2 or 3 SPACE, some old locations use TAB (width 8) and also some locations with TAB and SPACE mixed can be found.
The rule is to stay with the same style as used in the file before (2, 3 or 4 SPACE), but never mix SPACE and TAB in touched lines.
For new files, there is no old style to cover with, so 4 SPACE indention is expected.