Re: [PATCH 7/7] comctl32/taskdialog: Add support for TDF_RTL_LAYOUT.

[Nikolay Sivov]

On 05/16/2018 07:15 PM, Zhiyi Zhang wrote:
> Signed-off-by: Zhiyi Zhang
>
> dlls/comctl32/taskdialog.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/dlls/comctl32/taskdialog.c b/dlls/comctl32/taskdialog.c
> index 7066b793c8..5cd1d05642 100644
> --- a/dlls/comctl32/taskdialog.c
> +++ b/dlls/comctl32/taskdialog.c
> @@ -543,6 +543,7 @@ static DLGTEMPLATE *create_taskdialog_template(const TASKDIALOGCONFIG *taskconfi
>       template->style = DS_MODALFRAME | DS_SETFONT | WS_CAPTION | WS_VISIBLE | WS_SYSMENU;
>       if (taskconfig->dwFlags & TDF_CAN_BE_MINIMIZED) template->style |= WS_MINIMIZEBOX;
>       if (!(taskconfig->dwFlags & TDF_NO_SET_FOREGROUND)) template->style |= DS_SETFOREGROUND;
> -
>
> if (taskconfig->dwFlags & TDF_RTL_LAYOUT) template->dwExtendedStyle = WS_EX_LAYOUTRTL | WS_EX_RIGHT | WS_EX_RTLREADING;
>  template->cdit = desc.control_count;
>
> ptr = (char *)(template + 1);

This is probably correct on its own, but not enough to consider RTL mode 
supported. It should affect horizontal positions of about every control.