Re: [PATCH v4 1/5] server: Added support for tracking registered device notifications

[Micah N Gorrell]

Thank you. I'll make another attempt.

On Wed, Jun 12, 2019 at 05:13:32PM +0200, Alexandre Julliard wrote:
> Micah N Gorrell  writes:
> > diff --git a/server/user.h b/server/user.h
> > index eb1b7ce1e4..282cb63339 100644
> > --- a/server/user.h
> > +++ b/server/user.h
> > @@ -36,7 +36,8 @@ enum user_object
> >  {
> >      USER_WINDOW = 1,
> >      USER_HOOK,
> > - USER_CLIENT  /* arbitrary client handle */
> > - USER_CLIENT, /* arbitrary client handle */
> > - USER_DEVNOTIFY
>
> I don't think these should be user handles, especially since they don't
> work across processes. But if they are, you'd need some mechanism to
> clean them up when the client dies.
>
> To be honest I'm not convinced these should be in the server at
> all. Probably they could just as well be registered directly with the
> service that sends the notification.
>
> -- 
> Alexandre Julliard
> [e-mail]