On Mon, Sep 21, 2020 at 01:41:30PM +0000, Puetz Kevin A wrote:
On Monday, Sep 20, 2020 at 5:55 AM, Huw Davies wrote:
typeinfo_getnames() might be a better name for this helper; those with ITypeInfoImpl_* were helpers it's less likely to be confused with ITypeInfo_fnGetNames.
Ok. This one was like the others in that it's a helper adding a `dispinterface` arg to pass whether the top-level request was a dispinterface down the recursion into impltypes.
I indeed followed what seemed to be the naming convention of GetInternalFuncDesc That all ITypeInfoImpl_* were private helpers. But I it was unclear whether it was meant as (GetInternal)FuncDesc or Get(InternalFuncDesc), since that returned TLBFuncDesc instead of FUNCDESC, so I didn't put an "Internal" in this name.
I don't see any existing use of typelib_* naming. though I can certainly do that if it's you what you want. Should I lowercase the other helpers too, or just let this one use a different naming convention?
Or I suppose this could be ITypeInfoImpl_GetInternalNames,...
I think using typeinfo_getnames() is the moving in the right direction. There may be some scope to remain some of the other helpers at a later date.
Huw.