Re: [PATCH] vcomp140: Add vcomp140 stub

[Sebastian Lackner]

On 09.08.2016 05:31, Daniel Lehman wrote:
> 0001-vcomp140-Add-vcomp140-stub.txt
>
> From 4a1bccc08c4fce6c37921cc7d94d4e738433c92b Mon Sep 17 00:00:00 2001
> From: Daniel Lehman 
> Date: Mon, 8 Aug 2016 19:56:29 -0700
> Subject: [PATCH] vcomp140: Add vcomp140 stub
> Signed-off-by: Daniel Lehman
>
> configure.ac                |   1 +
>  dlls/vcomp140/Makefile.in   |   1 +
>  dlls/vcomp140/vcomp140.spec | 113 ++++++++++++++++++++++++++++++++++++++++++++
>  tools/make_specfiles        |   1 +
>  4 files changed, 116 insertions(+)
>  create mode 100644 dlls/vcomp140/Makefile.in
>  create mode 100644 dlls/vcomp140/vcomp140.spec

Thanks for working on this. Is there any specific reason why you omitted the DllMain
method? It might be better to return FALSE from DLL_WINE_PREATTACH to ensure the
native dll is preferred if available (like done in all other vcomp* dlls).

I would also be fine to switch vcomp to "prefer builtin" at some point, however I am
not sure if it is sufficiently tested yet. There are still various unimplemented
functions, so apps could stop working if they were using native vcomp140 before.
Other opinions are also welcome of course. ;)

Regards,
Sebastian