On Wed, Jun 03, 2020 at 06:25:13PM +1000, Alistair Leslie-Hughes wrote:
The BCG library registers just about every window it creates for Drag and Drop. The current method creates a file for each window registered for DnD, and in the case of a large application that uses BCG, 1000's of files can be created. Reducing the amount of file an application can use.
Sorry this has taken so long to review.
The new way, uses an unique guid for each regsitered window and then use that guid to lookup whether it supports Drag and Drop.
So this will start a new local server thread for each registration, which doesn't sound like an improvement. Possible other options include allocating a larger memory block which could be shared by a number of registrations or using the running object table.
Also, please try to update the existing comments when changing the implementation, this patch left several comments that were no longer correct.
Huw.