RE: [PATCH 1/2] kernel32: add GetConsoleFontInfo stub

[Hugh McMaster]

On Tuesday, 19 April 2016 11:25 AM, Austin English wrote:
> +BOOL WINAPI GetConsoleFontInfo(HANDLE hOutput, BOOL bMaximize, DWORD numFonts, CONSOLE_FONT *info)
> +{
> - FIXME("(%p %d %u %p): stub!\n", hOutput, bMaximize, numFonts, info);
> - SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> - return FALSE;
>
> +}

Please add this function after the GetConsoleFontSize function. We should keep the "Ex" functions in their own group
at the bottom of console.c.

Also, avoid Hungarian notation for bMaximize. That's okay for the HANLDE, although it should be hConsole.
to match the surrounding code.
> +/* Undocumented */
> +WINBASEAPI BOOL WINAPI   GetConsoleFontInfo(HANDLE, BOOL, DWORD, CONSOLE_FONT *);

I can't check right now, but I'm fairly certain GetConsoleFontInfo should not be included in wincon.h.
IIRC, this function cannot be called directly from a console program, only via GetModuleHandle and GetProcAddress.

--
Hugh McMaster